Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Agent header support #7

Merged
merged 11 commits into from
Oct 31, 2022
Merged

Agent header support #7

merged 11 commits into from
Oct 31, 2022

Conversation

sacOO7
Copy link
Collaborator

@sacOO7 sacOO7 commented Oct 26, 2022

  • Added agent header support with proper lib versioning.
  • Updated README for release process

@sacOO7
Copy link
Collaborator Author

sacOO7 commented Oct 26, 2022

@qsdstefan can you check if we can add a test to check for agent-header being sent.
You can check for the one here ->
https://github.com/ably/ably-php-laravel/blob/e3f564a2f526e1348f34a3d3b71f5dfc17bb0854/tests/AblyLaravelTest.php#L137

@sacOO7
Copy link
Collaborator Author

sacOO7 commented Oct 26, 2022

Implemented as a part of ably/ably-common#170

qsdstefan
qsdstefan approved these changes Oct 26, 2022
View reviewed changes
Copy link
Contributor

@qsdstefan qsdstefan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct!

@qsdstefan qsdstefan mentioned this pull request Oct 28, 2022
Closed
@qsdstefan qsdstefan marked this pull request as ready for review October 30, 2022 12:08
@sacOO7 sacOO7 requested a review from owenpearson October 30, 2022 12:39
@sacOO7 sacOO7 mentioned this pull request Oct 30, 2022
Closed
owenpearson
owenpearson requested changes Oct 31, 2022
View reviewed changes
Copy link
Member

@owenpearson owenpearson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good on the whole, a few things that need addressing.

Also, it seems like this PR conflates the agent header support with some unrelated documentation changes, I would prefer to have separate PRs for these if possible.

@sacOO7 sacOO7 requested a review from owenpearson October 31, 2022 12:02
@sacOO7 sacOO7 merged commit 42c7f20 into main Oct 31, 2022
@sacOO7 sacOO7 deleted the feature/agent-header branch October 31, 2022 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qsdstefan qsdstefan qsdstefan approved these changes

@owenpearson owenpearson owenpearson approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sacOO7 @qsdstefan @owenpearson