-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize request-response time #15
Conversation
… day, rename method
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any thoughts on why we need to disable some laravel/php combinations to make this work?
We are not actually disabling them. |
https://laravel.com/docs/8.x/releases#support-policy You can see in the chart PHP 8.1 is not compatible with laravel |
@sacOO7 thanks for explaining 👍 @qsdstefan fwiw it would be good to have that kind of information in the PR/commit description in future |
Good thinking, I did not refer to the Laravel support policy when setting up the matrix for tests, which lead to the issue in the first place. |
Ably
for gettingserver time
.Server time diff
is saved in local file cache.350ms
to150ms
on page loads where Ably server time was cached.Fixed #16