Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README, add support for pusher compatible broadcasters #10

Merged
merged 6 commits into from
Nov 3, 2022
Merged

Update README, add support for pusher compatible broadcasters #10

merged 6 commits into from
Nov 3, 2022

Conversation

sacOO7
Copy link
Collaborator

@sacOO7 sacOO7 commented Nov 2, 2022

  1. https://github.com/beyondcode/laravel-websockets and
  2. https://github.com/soketi/soketi
  • These are very popular libraries with 4k+ stars and can be replaced by new AblyBroadcaster.
  • Aim is to make it clear in the doc, that we support this type of migration.

@sacOO7 sacOO7 changed the title Refactor/doc Update README, add support for pusher compatible broadcasters Nov 2, 2022
owenpearson
owenpearson requested changes Nov 2, 2022
View reviewed changes
@sacOO7 sacOO7 requested a review from owenpearson November 2, 2022 15:56
qsdstefan
qsdstefan reviewed Nov 2, 2022
View reviewed changes
@sacOO7 sacOO7 requested a review from qsdstefan November 2, 2022 18:15
qsdstefan
qsdstefan approved these changes Nov 3, 2022
View reviewed changes
Copy link
Contributor

@qsdstefan qsdstefan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

owenpearson
owenpearson approved these changes Nov 3, 2022
View reviewed changes
Copy link
Member

@owenpearson owenpearson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sacOO7 sacOO7 merged commit d6b9663 into main Nov 3, 2022
@sacOO7 sacOO7 deleted the refactor/doc branch November 3, 2022 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qsdstefan qsdstefan qsdstefan approved these changes

@owenpearson owenpearson owenpearson approved these changes

Assignees

@qsdstefan qsdstefan

@owenpearson owenpearson

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sacOO7 @qsdstefan @owenpearson