Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add python SDK manifest #79

Merged
merged 7 commits into from
Oct 18, 2022
Merged

Add python SDK manifest #79

merged 7 commits into from
Oct 18, 2022

Conversation

AmirQSD
Copy link
Contributor

@AmirQSD AmirQSD commented Oct 14, 2022

No description provided.

@github-actions github-actions bot temporarily deployed to staging/pull/79/matrix October 14, 2022 11:36 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/79/matrix October 14, 2022 11:41 Inactive
Copy link
Contributor

@QuintinWillison QuintinWillison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, though I've not checked line by line against the Python codebase. I see that @owenpearson has kindly responded to @AmirQSD's questions (internal Slack thread), so it seems this pull request is in the correct state.

Copy link
Member

@owenpearson owenpearson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Channel -> Status -> ChannelDetails is implemented in ably-python so we'll need to add that. Everything else LGTM 👍

@github-actions github-actions bot temporarily deployed to staging/pull/79/matrix October 17, 2022 16:11 Inactive
@AmirQSD
Copy link
Contributor Author

AmirQSD commented Oct 17, 2022

Added Channel -> Status -> ChannelDetails @owenpearson

@AmirQSD AmirQSD requested a review from owenpearson October 17, 2022 16:16
Copy link
Member

@owenpearson owenpearson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@QuintinWillison QuintinWillison merged commit a9cbdd2 into main Oct 18, 2022
@QuintinWillison QuintinWillison deleted the python-sdk-manifest branch October 18, 2022 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Create Feature Compliance Manifest for ably-python
3 participants