Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WEB-4142] Add datadog lite on pricing #578

Merged
merged 2 commits into from
Dec 12, 2024

Conversation

denissellu
Copy link
Member

@denissellu denissellu commented Dec 12, 2024

Jira Ticket Link / Motivation

WEB-4142

Summary of changes

Summary by CodeRabbit

  • New Features

    • Updated "Pro" pricing plan to include "Datadog (lite)" in the list of included services.
  • Chores

    • Updated version number in the project configuration from 15.1.7 to 15.1.8.

Copy link
Contributor

coderabbitai bot commented Dec 12, 2024

Walkthrough

The pull request includes an update to the package.json file for the @ably/ui project, changing the version number from 15.1.7 to 15.1.8. Additionally, modifications were made to the planData array in the src/core/Pricing/data.tsx file, specifically enhancing the "Pro" pricing plan by adding "Datadog (lite)" to the list of included items. The changes are localized and do not affect other parts of the data structure.

Changes

File Change Summary
package.json Updated version from 15.1.7 to 15.1.8.
src/core/Pricing/data.tsx Modified "Includes" section for "Pro" plan to add "Datadog (lite)".

Assessment against linked issues

Objective Addressed Explanation
Update version in package.json (WEB-4142)
Enhance Pro plan features (WEB-4142)

Possibly related PRs

Suggested labels

review

Suggested reviewers

  • jamiehenson
  • aralovelace

🐰 In the garden where changes bloom,
A version update brings new room.
Pro plans enhanced with Datadog's light,
Hop along, all feels just right!
With each tweak, our project grows,
A joyful leap, as progress flows! 🌼


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6e22306 and 91b6116.

📒 Files selected for processing (2)
  • package.json (1 hunks)
  • src/core/Pricing/data.tsx (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • package.json
🔇 Additional comments (1)
src/core/Pricing/data.tsx (1)

135-135: LGTM! Verify feature naming consistency.

The addition of "Datadog (lite)" to the Pro plan's features aligns well with the tiered feature strategy, where Enterprise plans get the full "Datadog" integration while Pro plans get the lite version.

Let's verify the naming consistency across the codebase:

✅ Verification successful

Feature naming is consistent across the codebase

The naming convention for Datadog features is consistent throughout the codebase:

  • Pro plan: "Datadog (lite)"
  • Enterprise plan: "Datadog"

The only other mentions are related to technical icons (icon-tech-datadog), which are unrelated to the feature naming.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check for consistent naming of Datadog features
# Expected: Should find "Datadog (lite)" and "Datadog" to verify naming patterns

# Search for Datadog mentions to ensure consistent naming
rg -i "datadog" --type tsx --type ts

Length of output: 64


Script:

#!/bin/bash
# Let's try a different approach by searching all files for Datadog mentions
# without file type restrictions, as the extension might be different
rg -i "datadog" -A 2 -B 2

Length of output: 1531


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Experiment)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@denissellu denissellu changed the title [WEB-4142] Add datadog lite from pricing [WEB-4142] Add datadog lite on pricing Dec 12, 2024
Copy link
Member

@jamiehenson jamiehenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woof woof

@denissellu denissellu merged commit 9cdcbf7 into main Dec 12, 2024
4 checks passed
@denissellu denissellu deleted the add-datadog-lite-from-pricing branch December 12, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants