Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enabled TLS hostname validation CVE-2020-13482 #263

Merged
merged 4 commits into from
Aug 3, 2021
Merged

Enabled TLS hostname validation CVE-2020-13482 #263

merged 4 commits into from
Aug 3, 2021

Conversation

ghost
Copy link

@ghost ghost commented Jul 28, 2021

TLS hostname validation CVE-2020-13482
igrigorik/em-http-request#339 for details.

Added tls: { verify_peer: true } parameter to EventMachine::HttpRequest.new()

@ghost ghost self-assigned this Jul 28, 2021
@ghost ghost marked this pull request as ready for review August 3, 2021 11:16
@ghost ghost requested review from owenpearson and TheSmartnik August 3, 2021 11:16
owenpearson
owenpearson approved these changes Aug 3, 2021
View reviewed changes
Copy link
Member

@owenpearson owenpearson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@owenpearson owenpearson merged commit 7d6a761 into main Aug 3, 2021
@owenpearson owenpearson deleted the event_machine-http_request-tls-verify_peer_fix branch August 3, 2021 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheSmartnik TheSmartnik Awaiting requested review from TheSmartnik

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@owenpearson