Feature/rest history integration tests #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiholic
force-pushed
the
feature/lint-dart
branch
from
1518a13 to
41ee031
Compare
tiholic
force-pushed
the
feature/rest-history-integration-tests
branch
from
e25c179 to
3007dea
Compare
tiholic
force-pushed
the
feature/lint-dart
branch
from
41ee031 to
a0577ec
Compare
tiholic
force-pushed
the
feature/rest-history-integration-tests
branch
2 times, most recently
from
27f732f to
000915a
Compare
tiholic
force-pushed
the
feature/lint-dart
branch
from
fd08700 to
ec1e2e3
Compare
tiholic
force-pushed
the
feature/rest-history-integration-tests
branch
from
7fff784 to
1b994a9
Compare
tiholic
force-pushed
the
feature/lint-dart
branch
from
ec1e2e3 to
80dff88
Compare
history can be queried based on the provided params
paginated history isn't always consistent
tiholic
force-pushed
the
feature/rest-history-integration-tests
branch
from
1b994a9 to
a8bc0a6
Compare
QuintinWillison
approved these changes
Feb 15, 2021
| await Future.delayed(const Duration(seconds: 2)); | ||
|
|
||
| final time1 = DateTime.now(); | ||
| //TODO(tiholic) iOS fails without this delay |
There was a problem hiding this comment.
Could you please ensure there's an issue for these TODO comments relating to the delays required so we can keep track of this technical debt.
| static const String restPublishWithAuthCallback = | ||
| 'restPublishWithAuthCallback'; | ||
| // TODO(tiholic) handle restHistoryWithAuthCallback |
There was a problem hiding this comment.
Again, it looks like we should manage this deferred work with an issue.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding integration tests for Rest History
paginationdirectionstartstartandend