Code

Feature/lint dart#67

Code

Merged

QuintinWillison merged 57 commits intointegration/stage-2ably/ably-flutter:integration/stage-2from feature/lint-dartably/ably-flutter:feature/lint-dartCopy head branch name to clipboardFeb 15, 2021

+2,396-1,956

Commits

Commits on Jan 12, 2021

• using composition over category to support hasAuthCallback

  tiholic

  committed
  ccf5ab0

  Copy full SHA for ccf5ab0

• Basis for discussion about what linter rules to enable

  

  zoechi

  authored and

  tiholic

  committed
  9aadb40

  Copy full SHA for 9aadb40

• removing non-nullable experimental analyzer flag

  tiholic

  committed
  9567ec4

  Copy full SHA for 9567ec4

• enabling missing_whitespace_between_adjacent_strings lint rule

  tiholic

  committed
  910ed7a

  Copy full SHA for 910ed7a

• enabling missing_whitespace_between_adjacent_strings lint rule

  tiholic

  committed
  6ebe197

  Copy full SHA for 6ebe197

• cleaning up some lint rules

  tiholic

  committed
  f0875a4

  Copy full SHA for f0875a4

• disabling: avoid_unused_constructor_parameters, diagnostic_describe_all_properties

  Show description for 4a71562
  tiholic

  committed
  4a71562

  Copy full SHA for 4a71562

• [dart-analyzer] changes related to "implicit-casts"

  tiholic

  committed
  6e254a5

  Copy full SHA for 6e254a5

• [lint] await_only_futures

  tiholic

  committed
  582fe88

  Copy full SHA for 582fe88

• [lint] Applying studio auto format + lines_longer_than_80_chars

  tiholic

  committed
  cd78fa0

  Copy full SHA for cd78fa0

• [lint] annotate_overrides

  tiholic

  committed
  3da2568

  Copy full SHA for 3da2568

• [lint] avoid_types_on_closure_parameters

  tiholic

  committed
  cfd58d2

  Copy full SHA for cfd58d2

• [lint] avoid_annotating_with_dynamic

  tiholic

  committed
  ca08a9e

  Copy full SHA for ca08a9e

• [lint] avoid_void_async

  tiholic

  committed
  216fa8e

  Copy full SHA for 216fa8e

• [lint] avoid_catches_without_on_clauses

  tiholic

  committed
  ecbc1de

  Copy full SHA for ecbc1de

• [lint] avoid_positional_boolean_parameters

  tiholic

  committed
  580ab10

  Copy full SHA for 580ab10

• [lint] prefer_expression_function_bodies

  tiholic

  committed
  110b5bd

  Copy full SHA for 110b5bd

• [lint] unnecessary_brace_in_string_interps

  tiholic

  committed
  23e62d6

  Copy full SHA for 23e62d6

• [lint] avoid_function_literals_in_foreach_calls

  tiholic

  committed
  c74a3c5

  Copy full SHA for c74a3c5

• [lint] cascade_invocations

  tiholic

  committed
  dc5ba3f

  Copy full SHA for dc5ba3f

• [lint] unnecessary_this

  tiholic

  committed
  7bdc28b

  Copy full SHA for 7bdc28b

• code cleanup on tests

  tiholic

  committed
  de04618

  Copy full SHA for de04618

• [lint] omit_local_variable_types, prefer_final_locals, prefer_const_declarations

  tiholic

  committed
  eb7248e

  Copy full SHA for eb7248e

• [lint] prefer_single_quotes

  Show description for b650c5a
  tiholic

  committed
  b650c5a

  Copy full SHA for b650c5a

• [lint] prefer_expression_function_bodies

  tiholic

  committed
  9da945c

  Copy full SHA for 9da945c

• [lint] unnecessary_await_in_return

  tiholic

  committed
  156f9a0

  Copy full SHA for 156f9a0

• [lint] prefer_relative_imports

  tiholic

  committed
  943a69d

  Copy full SHA for 943a69d

• [lint] constant_identifier_names

  tiholic

  committed
  1eb2692

  Copy full SHA for 1eb2692

• [lint] prefer_is_not_operator

  tiholic

  committed
  b69f752

  Copy full SHA for b69f752

• [lint] prefer_final_locals

  tiholic

  committed
  d8dd467

  Copy full SHA for d8dd467

• [lint] unnecessary_lambdas

  tiholic

  committed
  07e9a54

  Copy full SHA for 07e9a54

• [lint] prefer_const_constructors

  tiholic

  committed
  7ca216a

  Copy full SHA for 7ca216a

• [lint] prefer_generic_function_type_aliases

  tiholic

  committed
  9afd835

  Copy full SHA for 9afd835

• [lint] omit_local_variable_types

  tiholic

  committed
  0befc49

  Copy full SHA for 0befc49

• [lint] unused_local_variable

  tiholic

  committed
  57ada24

  Copy full SHA for 57ada24

• [lint] prefer_asserts_in_initializer_lists

  tiholic

  committed
  b558bcd

  Copy full SHA for b558bcd

• [lint] always_declare_return_types

  tiholic

  committed
  7b52794

  Copy full SHA for 7b52794

• [lint] prefer_initializing_formals, prefer_final_fields

  tiholic

  committed
  d93b755

  Copy full SHA for d93b755

• [lint] avoid_print

  tiholic

  committed
  ec4f1a5

  Copy full SHA for ec4f1a5

• [lint] only_throw_errors

  tiholic

  committed
  b79d736

  Copy full SHA for b79d736

• [lint] type_annotate_public_apis

  tiholic

  committed
  dc2e9d0

  Copy full SHA for dc2e9d0

• [lint] avoid_returning_null, close_sinks

  tiholic

  committed
  dcf53ef

  Copy full SHA for dcf53ef

• Update with newest lints and clean up formatting and comments

  

  zoechi

  authored and

  tiholic

  committed
  fd15cba

  Copy full SHA for fd15cba

• trailing comma's - saves tonnes of time by auto-formatting the dart code better

  tiholic

  committed
  7458b4b

  Copy full SHA for 7458b4b

• making necessary variables const

  Show description for 4ffa25c
  tiholic

  committed
  4ffa25c

  Copy full SHA for 4ffa25c

• asserting fetchHandle to be non-null while creating a PlatformObject

  tiholic

  committed
  a04a581

  Copy full SHA for a04a581

• using => over {}

  tiholic

  committed
  b493d41

  Copy full SHA for b493d41

• improvise documentation

  tiholic

  committed
  0ec0e3a

  Copy full SHA for 0ec0e3a

• removing analysis_options.yaml from example, so rules from package are applied

  tiholic

  committed
  3dc1ba4

  Copy full SHA for 3dc1ba4

• fix decoding paginated result post linting

  tiholic

  committed
  8a03418

  Copy full SHA for 8a03418

• fix history list in case of no items

  tiholic

  committed
  7bf935e

  Copy full SHA for 7bf935e

• [lint] fixing diagnostic errors post stage 1 rebase

  Show description for 8b9bf63
  tiholic

  committed
  8b9bf63

  Copy full SHA for 8b9bf63

• [lint] fixing lints post rebase over stage 1

  tiholic

  committed
  f7b5e7d

  Copy full SHA for f7b5e7d

• [lint] fixing lints in test_integration post rebase over stage 1

  tiholic

  committed
  1a50b6e

  Copy full SHA for 1a50b6e

• fix publishing bug - post rebase linting (stage 1)

  Show description for bcf52ef
  tiholic

  committed
  bcf52ef

  Copy full SHA for bcf52ef

• increasing test timeout

  tiholic

  committed
  80dff88

  Copy full SHA for 80dff88

Commits on Feb 15, 2021

• Merge branch 'feature/rest-channel-history' into feature/lint-dart

  QuintinWillison

  committed
  16160ec

  Copy full SHA for 16160ec