-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate activation broadcast receiver from channel handler class #307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…AttachedToEngine and onDetachedFromEngine callbacks
ikbalkaya
added
bug
Something isn't working. It's clear that this does need to be fixed.
code-quality
Affects the developer experience when working in our codebase.
labels
Jan 25, 2022
KacperKluka
approved these changes
Jan 25, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good 👍 One small problem but it was present before so I'll let you decide what to do with it 😉
android/src/main/java/io/ably/flutter/plugin/push/PushActivationEventHandlers.java
Show resolved
Hide resolved
ikurek
approved these changes
Feb 1, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🙂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working. It's clear that this does need to be fixed.
code-quality
Affects the developer experience when working in our codebase.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes activation handling code by
PushActivationHandlers
singleton, by providing an instance method and converting some static methods into instance methodsCloses #304
Please note that changes here won't cause a manual application launch, meaning that any message from broadcast receiver will be received only when the Flutter engine is attached. I did this to prevent further bugs raising from inconsistencies related to Flutter engine lifecycle.
However this is still a temporary solution. A full solution would be to separate third party push plugin so that we can reuse code directly from Firebase library (#292) or completely refactor push notification code on our plugin
Note: Java library will send activation results using broadcasts. That method might have been chosen for native Android apps, but it could be nice if we could have a async alternative that would give results through callback. If so we wouldn't need to deal with broadcast receivers on our plugin.