Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename variables to be more meaningful #262

Merged
merged 2 commits into from
Jan 19, 2022

Conversation

ben-xD
Copy link
Contributor

@ben-xD ben-xD commented Nov 26, 2021

I had previously had these renames in a different PR (#252), but reverted the commit which renamed this variables because it was taking too much attention.

This PR only renames some variables in objective-C, and replaces dictionary access to the square bracket syntax.

@ben-xD ben-xD added the enhancement New feature or improved functionality. label Nov 26, 2021
@ben-xD ben-xD self-assigned this Nov 26, 2021
@github-actions github-actions bot temporarily deployed to staging/pull/262/dartdoc November 26, 2021 22:14 Inactive
Base automatically changed from enhancement/ios/linter-warning to enhancement/package-descriptions December 8, 2021 08:30
@ben-xD ben-xD requested a review from ikbalkaya December 8, 2021 10:40
Copy link
Contributor

@ikbalkaya ikbalkaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from enhancement/package-descriptions to main January 19, 2022 19:29
# Conflicts:
#	ios/Classes/codec/AblyFlutterReader.m
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or improved functionality.
Development

Successfully merging this pull request may close these issues.

4 participants