Fix 2 Channel options bugs #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-for-channel-options
ben-xD
changed the title
ikbalkaya
suggested changes
Nov 1, 2021
android/src/main/java/io/ably/flutter/plugin/AblyMessageCodec.java
Outdated
Show resolved
Hide resolved
QuintinWillison
approved these changes
Nov 1, 2021
ikbalkaya
approved these changes
Nov 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are 2 bug fixes in here:
1 in Ably-java: It was wrongly assumed that Ably-java does not support channel modes. It does, and here I add support for it.
1 in Ably-cocoa: The wrong Ably-cocoa method was used, and in this case, causes a runtime crash whenever a user sets options on a realtime channel. This has happened because code was copy pasted on not ran or validated.
There is one enhancement regarding the cipher passed to channel options. You can see this in
createChannelOptions(@Nullable Object cipher). Previously, in Ably-java, we assume the cipher to be a String, causing a crash if it wasn't. Now, I add support for byte array, as well as logging information out if the cipher is not a string or a byte array.