constants to use lowerCamelCase

ref: https://dart.dev/guides/language/effective-dart/style#prefer-using-lowercamelcase-for-constant-names - Resolution for comment #4 (comment)
ably · May 5, 2020 · cbf0f5f · cbf0f5f
1 parent 67cee6d
commit cbf0f5f
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 9 deletions.
diff --git a/example/lib/main.dart b/example/lib/main.dart
@@ -94,7 +94,7 @@ class _MyAppState extends State<MyApp> {
 
     final clientOptions = ably.ClientOptions.fromKey(_appKey.toString());
     clientOptions.environment = 'sandbox';
-    clientOptions.logLevel = ably.LogLevel.VERBOSE;
+    clientOptions.logLevel = ably.LogLevel.verbose;
     clientOptions.logHandler = ({String msg, ably.AblyException exception}){
       print("Custom logger :: $msg $exception");
     };
@@ -127,7 +127,7 @@ class _MyAppState extends State<MyApp> {
 
     final clientOptions = ably.ClientOptions.fromKey(_appKey.toString());
     clientOptions.environment = 'sandbox';
-    clientOptions.logLevel = ably.LogLevel.VERBOSE;
+    clientOptions.logLevel = ably.LogLevel.verbose;
     clientOptions.logHandler = ({String msg, ably.AblyException exception}){
       print("Custom logger :: $msg $exception");
     };

diff --git a/lib/src/spec/constants.dart b/lib/src/spec/constants.dart
@@ -1,8 +1,8 @@
 class LogLevel{
-  static final int NONE = 99;
-  static final int VERBOSE = 2;
-  static final int DEBUG = 3;
-  static final int INFO = 4;
-  static final int WARN = 5;
-  static final int ERROR = 6;
+  static final int none = 99;
+  static final int verbose = 2;
+  static final int debug = 3;
+  static final int info = 4;
+  static final int warn = 5;
+  static final int error = 6;
 }
diff --git a/test/ably_api_unit_test.dart b/test/ably_api_unit_test.dart
@@ -8,7 +8,7 @@ void main() {
   test('Default ClientOptions', () { 
     final clientOptions = ClientOptions();
     expect(clientOptions.clientId, isNull);
-    expect(clientOptions.logLevel, LogLevel.INFO);
+    expect(clientOptions.logLevel, LogLevel.info);
     expect(clientOptions.logHandler, isNull);
     expect(clientOptions.tls, isNull);
     expect(clientOptions.restHost, isNull);