Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ECO-4711] Added deviceSecret in device registration POST. #1893

Merged
merged 3 commits into from
Mar 26, 2024
Merged

[ECO-4711] Added deviceSecret in device registration POST. #1893

merged 3 commits into from
Mar 26, 2024

Conversation

maratal
Copy link
Collaborator

@maratal maratal commented Mar 24, 2024

Closes #1892

@github-actions github-actions bot temporarily deployed to staging/pull/1893/features March 24, 2024 23:03 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1893/jazzydoc March 24, 2024 23:09 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1893/features March 25, 2024 13:10 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1893/jazzydoc March 25, 2024 13:15 Inactive
@maratal maratal requested review from sacOO7 and umair-ably March 25, 2024 16:05
@maratal maratal marked this pull request as ready for review March 25, 2024 16:05
@maratal maratal merged commit 2fc86d7 into main Mar 26, 2024
7 checks passed
@maratal maratal deleted the fix/1892-deviceSecret-in-registration branch March 26, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@umair-ably umair-ably umair-ably approved these changes

@sacOO7 sacOO7 Awaiting requested review from sacOO7

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Device registration flow omits deviceSecret (both in code and documentation)
2 participants
@maratal @umair-ably