Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

template: save default config from template #485

Closed

Conversation

hfqin0
Copy link

@hfqin0 hfqin0 commented Nov 18, 2022

I found colima can not update the default config when I run colima template.
E.g.,
I change the kubernetes version in the template by running colima tempalte
image
but the version in the default config does not change when I run colima start --edit
image

This PR fixes it.

@hfqin0 hfqin0 closed this Nov 18, 2022
@abiosoft
Copy link
Owner

The template is not meant for modifying the default profile's config. Rather, it is meant to be the initial config for a newly created VM. i.e. if you were to start afresh.

If you need to modify your current config, you can simply colima start --edit or edit the config file directly in ~/.colima/default/colima.yaml.

It is mainly useful for those that spin up multiple instances or frequently teardown the VM.

@hftsin
Copy link
Contributor

hftsin commented Nov 18, 2022

yes, thanks for your explanation for the template command. In my daily use of colima, i want to save the latest config that updated from --edit. So do you think it is necessary to update the default config once we edit it?

@abiosoft
Copy link
Owner

abiosoft commented Nov 18, 2022

Oh, gotcha. You are likely hitting the bug specific to saving Kubernetes version #417.
It was fixed in #442 but has not been released yet.

You can brew install --HEAD colima to use the development version (that includes the fix) for now, until the next release.

Thanks.

@abiosoft
Copy link
Owner

FYI any changes you make during --edit will persist.

@hftsin
Copy link
Contributor

hftsin commented Nov 18, 2022

Oh, gotcha. You are likely hitting the bug specific to saving Kubernetes version #417. It was fixed in #442 but has not been released yet.

You can brew install --HEAD colima to use the development version (that includes the fix) for now, until the next release.

Thanks.

Yes, that is what I need. Thanks for your kind work.

@hftsin hftsin deleted the fix/save-template-to-default-config branch November 18, 2022 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants