Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update versions of crypto dependencies #13

Merged

Conversation

Fabma
Copy link

@Fabma Fabma commented Mar 31, 2020

The changes in asn1crypto required minor changes. Responding to the
following changes in asn1crpyto's changelog:

  • cms.KeyEncryptionAlgorithmId().native now returns the value "rsaes_pkcs1v15" for OID 1.2.840.113549.1.1.1 instead of "rsa"
  • Added RC4 (1.2.840.113549.3.4) to algos.EncryptionAlgorithmId()
  • Require timezone-aware datetime

The changes in asn1crypto required minor changes. Responding to the
following changes in asn1crpyto's changelog:
- cms.KeyEncryptionAlgorithmId().native now returns the value "rsaes_pkcs1v15" for OID 1.2.840.113549.1.1.1 instead of "rsa"
- Added RC4 (1.2.840.113549.3.4) to algos.EncryptionAlgorithmId()
- Require timezone-aware datetime
@codecov
Copy link

codecov bot commented Mar 31, 2020

Codecov Report

Merging #13 into master will not change coverage by %.
The diff coverage is 66.66%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #13   +/-   ##
=======================================
  Coverage   94.01%   94.01%           
=======================================
  Files           6        6           
  Lines         702      702           
  Branches      122      122           
=======================================
  Hits          660      660           
  Misses         26       26           
  Partials       16       16           
Impacted Files Coverage Δ
pyas2lib/cms.py 85.93% <66.66%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50dcec0...e0789e6. Read the comment docs.

@abhishek-ram abhishek-ram merged commit 444c922 into abhishek-ram:master Apr 4, 2020
@Fabma Fabma deleted the bump_up_dependency_versions branch May 11, 2020 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants