Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows support #387

Merged
merged 1 commit into from
Sep 14, 2024
Merged

Windows support #387

merged 1 commit into from
Sep 14, 2024

Conversation

abhinav
Copy link
Owner

@abhinav abhinav commented Sep 7, 2024

This adds support for using git-spice with Windows.
I'm pretty sure it already works, but testing it is a bit difficult,
especially since I don't have a Windows system to test on.

All terminal prompt use creack/pty to create a fake terminal.
Until creack/pty#155 is merged, these tests cannot be run on Windows.
We'll skip the prompt tests on Windows for the time being.

@abhinav
Copy link
Owner Author

abhinav commented Sep 7, 2024

This change is part of the following stack:

Change managed by git-spice.

@abhinav abhinav force-pushed the windows branch 8 times, most recently from 431eec6 to d31fa9f Compare September 8, 2024 19:08
@abhinav abhinav changed the title [wip] test against windows [wip] Windows support Sep 8, 2024
@abhinav abhinav force-pushed the windows branch 4 times, most recently from 0072064 to f3b911d Compare September 14, 2024 19:50
Adds Windows to the test matrix. We'll see what breaks.
For creack/pty, we need to use the currently-unmerged change for Windows
support.
@abhinav abhinav changed the title [wip] Windows support Windows support Sep 14, 2024
@abhinav abhinav marked this pull request as ready for review September 14, 2024 20:14
@abhinav abhinav merged commit d405d49 into main Sep 14, 2024
10 checks passed
@abhinav abhinav deleted the windows branch September 14, 2024 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant