Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix layer ID determination to use only the first group of contiguous digit #606

Merged
merged 2 commits into from
Mar 11, 2023

Conversation

abey79
Copy link
Owner

@abey79 abey79 commented Mar 11, 2023

Description

This address WTF cases like 01-layer1 ending in layer 11, but does not address cases like both green1 and blue1 ending in layer 1 (#594). This would require use the AxiDraw semantic (layer ID must be the first non-whitespace character), but would break situation like layer 1 and layer 3.

Checklist

  • feature/fix implemented
  • code formatting ok (black and isort)
  • mypy returns no error
  • tests added/updated and pytest succeeds
  • documentation added/updated
    • command docstring and option/argument help
    • README.md updated (Feature Overview)
    • CHANGELOG.md updated
    • added new command to reference.rst
    • RTD doc updated and building with no error (make clean && make html in docs/)

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Mar 11, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01 🎉

Comparison is base (292f1b3) 94.74% compared to head (85d063f) 94.76%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #606      +/-   ##
==========================================
+ Coverage   94.74%   94.76%   +0.01%     
==========================================
  Files          62       62              
  Lines        5690     5710      +20     
  Branches     1302     1304       +2     
==========================================
+ Hits         5391     5411      +20     
  Misses        182      182              
  Partials      117      117              
Impacted Files Coverage Δ
vpype_cli/read.py 96.22% <ø> (ø)
tests/test_files.py 98.63% <100.00%> (+0.09%) ⬆️
vpype/io.py 85.27% <100.00%> (+0.21%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@abey79 abey79 merged commit 88398fa into master Mar 11, 2023
@abey79 abey79 deleted the better-layer-id branch March 11, 2023 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant