Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add special case handling for layout tight #556

Merged
merged 2 commits into from
Oct 13, 2022
Merged

Conversation

abey79
Copy link
Owner

@abey79 abey79 commented Oct 13, 2022

Description

The command layout tight now fits the page size around the existing geometries, accommodating for a margin if provided.

With an empty pipeline, layout tight has no effect (in contrast to other value of SIZE, where the page size is changed).

Fixes #201

Checklist

  • feature/fix implemented
  • code formatting ok (black and isort)
  • mypy returns no error
  • tests added/updated and pytest succeeds
  • documentation added/updated
    • command docstring and option/argument help
    • README.md updated (Feature Overview)
    • CHANGELOG.md updated
    • added new command to reference.rst
    • RTD doc updated and building with no error (make clean && make html in docs/)

The command `layout tight` now fits the page size around the existing geometries, accommodating for a margin if provided.

With an empty pipeline, `layout tight` has no effect (in contrast to other value of SIZE, where the page size is changed).

Fixes #201
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Oct 13, 2022

Codecov Report

Base: 94.72% // Head: 94.73% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (638ba53) compared to base (af8b76f).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #556      +/-   ##
==========================================
+ Coverage   94.72%   94.73%   +0.01%     
==========================================
  Files          62       62              
  Lines        5668     5681      +13     
  Branches      765      767       +2     
==========================================
+ Hits         5369     5382      +13     
  Misses        182      182              
  Partials      117      117              
Impacted Files Coverage Δ
tests/test_commands.py 99.08% <100.00%> (+0.01%) ⬆️
vpype_cli/operations.py 97.07% <100.00%> (+0.05%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@abey79 abey79 merged commit 344d110 into master Oct 13, 2022
@abey79 abey79 deleted the feature-layout-tight branch October 13, 2022 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: layout tight does a 0x0 page instead of a tight layout
1 participant