Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added m and ft units #498

Merged
merged 2 commits into from
Jun 22, 2022
Merged

Added m and ft units #498

merged 2 commits into from
Jun 22, 2022

Conversation

abey79
Copy link
Owner

@abey79 abey79 commented Jun 22, 2022

Description

Longer units are useful for the new splitdist command (#487).

Also cleaned some dev deps.

Checklist

  • feature/fix implemented
  • code formatting ok (black and isort)
  • mypy returns no error
  • tests added/updated and pytest succeeds
  • documentation added/updated
    • command docstring and option/argument help
    • README.md updated (Feature Overview)
    • CHANGELOG.md updated
    • added new command to reference.rst
    • RTD doc updated and building with no error (make clean && make html in docs/)

Also cleaned some dev deps.
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Jun 22, 2022

Codecov Report

Merging #498 (21609ff) into master (c1e896f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #498   +/-   ##
=======================================
  Coverage   94.43%   94.44%           
=======================================
  Files          60       61    +1     
  Lines        5443     5451    +8     
  Branches      793      794    +1     
=======================================
+ Hits         5140     5148    +8     
  Misses        185      185           
  Partials      118      118           
Impacted Files Coverage Δ
vpype/utils.py 95.00% <ø> (ø)
tests/test_utils.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1e896f...21609ff. Read the comment docs.

@abey79 abey79 merged commit fa15d30 into master Jun 22, 2022
@abey79 abey79 deleted the feature-meterfeet branch June 22, 2022 07:49
abey79 added a commit that referenced this pull request Jul 4, 2022
This commit documents the changes introduced in #498
abey79 added a commit that referenced this pull request Jul 4, 2022
This commit documents the changes introduced in #498
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant