Improved handling of pen width and opacity in viewer #448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The viewer now honors pen width and opacity - The corresponding menu items have now been renamed "Default pen opacity" and "Default pen width" - Added an "Override" menu item to both menu to override pen width/opacity from properties - API (breaking change): engine renamed `pen_width`/`pen_opacity` property to `default_pen_width`/`default_pen_opacity` - API (breaking change): renamed parameters of `vpype_viewer.render_image()`
Codecov Report
@@ Coverage Diff @@
## master #448 +/- ##
==========================================
+ Coverage 94.34% 94.38% +0.04%
==========================================
Files 60 60
Lines 5355 5396 +41
Branches 783 786 +3
==========================================
+ Hits 5052 5093 +41
Misses 185 185
Partials 118 118
Continue to review full report at Codecov.
|
… offset by 0.5 pixel in order to be aligned with the pixel grid and avoid rounding errors.
…e which leads to rounding errors.
- Added viewer test with metadata
- updated deps
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR improves the viewer so it honours the pen width and opacity (
vp_color's alpha channel) when present. The UI is updated to reflect that the choosable pen width/opacity are now default value, used when they are undefined. It also adds options to override the pen width/opacity from the properties and use the default value instead.Done:
test_text_block_render()pen_width/pen_opacityproperty todefault_pen_width/default_pen_opacityvpype_viewer.render_image()TODO:
Fixes #377
Fixes #375
Checklist
blackandisort)mypyreturns no errorpytestsucceedshelpreference.rstmake clean && make htmlindocs/)