Improve handling of SVG with missing width and height. #446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When width and height are missing from the <svg> tag, or expressed as percent, we now let svgelement use viewBox (if available) or revert to 1000x1000. This happens by default now with `read_svg()` (and friends). This behaviour can be overridden by passing values for `default_width` and `default_height`. The `read` command now follows this pattern as well. Fixes #441
- Update CHANGELOG.md
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## master #446 +/- ##
=======================================
Coverage 94.31% 94.32%
=======================================
Files 60 60
Lines 5313 5339 +26
Branches 778 781 +3
=======================================
+ Hits 5011 5036 +25
Misses 185 185
- Partials 117 118 +1
Continue to review full report at Codecov.
|
abey79
added a commit
that referenced
this pull request
Apr 2, 2022
…#446) - Fixed missing alpha in __all__ - Updated CHANGELOG.md
10 tasks
abey79
added a commit
that referenced
this pull request
Apr 2, 2022
There was no way to adjust a layer's opacity without providing the base colour, which may have been set already. This PR introduce the `alpha` command, which does exactly that. If no colour is defined for the layer, it is set to black. Also: - added `vpype_cli.FloatRangeType` - fixed typo in `vpype_cli.IntRangeType` docstring - fixed misnamed `vpype.Color.as_rgb_hex()` member name - added test for `alpha` - updated doc and readme - Fixed error in `test_read_command_page_size()` on Windows introduced in #446
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When width and height are missing from the tag, or expressed as percent, we now let svgelement use viewBox (if available) or revert to 1000x1000. This happens by default now with
read_svg()(and friends). This behaviour can be overridden by passing values fordefault_widthanddefault_height.The
readcommand now follows this pattern as well.Fixes #441
Checklist
blackandisort)mypyreturns no errorpytestsucceedshelpreference.rstmake clean && make htmlindocs/)