Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added an option to write to skip the date metadata #442

Merged
merged 2 commits into from
Mar 31, 2022
Merged

Added an option to write to skip the date metadata #442

merged 2 commits into from
Mar 31, 2022

Conversation

abey79
Copy link
Owner

@abey79 abey79 commented Mar 31, 2022 •
edited
Loading

Description

For auto-generated SVG under VCS, the dc:date metadata generates spurious diffs which would be best avoided.

  • adds a --dont-set-date option to the write command
  • adds a set_date parameter (default: True) to the vpype.write_svg() API

Fixes #438

Checklist

  • feature/fix implemented
  • code formatting ok (black and isort)
  • mypy returns no error
  • tests added/updated and pytest succeeds
  • documentation added/updated
    • command docstring and option/argument help
    • README.md updated (Feature Overview)
    • CHANGELOG.md updated
    • added new command to reference.rst
    • RTD doc updated and building with no error (make clean && make html in docs/)

@abey79
Added an option to write to skip the date metadata
e9514cc 
For auto-generated SVG under VCS, the <dc:date> metadata generates spurious diffs which would be best avoided.

* adds a `--dont-set-date` option to the `write` command
* adds a `set_date` parameter (default: `True`) to the `vpype.write_svg()` API
@codecov
Copy link

codecov bot commented Mar 31, 2022 •
edited
Loading

Codecov Report

Merging #442 (5baf1bf) into master (9d300d0) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #442      +/-   ##
==========================================
+ Coverage   93.96%   93.97%   +0.01%     
==========================================
  Files          60       60              
  Lines        5288     5298      +10     
  Branches      775      776       +1     
==========================================
+ Hits         4969     4979      +10     
  Misses        204      204              
  Partials      115      115
Impacted Files Coverage Δ
tests/test_files.py 98.88% <100.00%> (+0.05%) ⬆️
vpype/io.py 84.65% <100.00%> (+0.03%) ⬆️
vpype_cli/write.py 85.96% <100.00%> (+0.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d300d0...5baf1bf. Read the comment docs.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@abey79 abey79 merged commit 22e2dab into master Mar 31, 2022
@abey79 abey79 deleted the feature-write-no-date branch March 31, 2022 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a --no-date option to write
1 participant
@abey79