Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Document.add_to_sources() to also set vp_source #431

Merged
merged 3 commits into from
Mar 27, 2022

Conversation

abey79
Copy link
Owner

@abey79 abey79 commented Mar 27, 2022

Description

This makes it a more useful API for plug-ins. Also, ValueError is no longer silenced.

Fixes #412

Checklist

  • feature/fix implemented
  • code formatting ok (black and isort)
  • mypy returns no error
  • tests added/updated and pytest succeeds
  • documentation added/updated
    • command docstring and option/argument help
    • README.md updated (Feature Overview)
    • CHANGELOG.md updated
    • added new command to reference.rst
    • RTD doc updated and building with no error (make clean && make html in docs/)

abey79 added 2 commits March 27, 2022 19:23
This makes it a more useful API for plug-ins. Also, `ValueError` is no longer silenced.
@codecov
Copy link

codecov bot commented Mar 27, 2022

Codecov Report

Merging #431 (0fbb7e7) into master (b3907ed) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #431      +/-   ##
==========================================
+ Coverage   93.93%   93.96%   +0.03%     
==========================================
  Files          60       60              
  Lines        5276     5288      +12     
  Branches      774      775       +1     
==========================================
+ Hits         4956     4969      +13     
  Misses        204      204              
+ Partials      116      115       -1     
Impacted Files Coverage Δ
vpype/io.py 84.61% <ø> (-0.08%) ⬇️
tests/test_model.py 100.00% <100.00%> (ø)
vpype/model.py 92.04% <100.00%> (+0.26%) ⬆️
vpype_cli/read.py 96.07% <100.00%> (+0.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3907ed...0fbb7e7. Read the comment docs.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@abey79 abey79 merged commit 5992728 into master Mar 27, 2022
@abey79 abey79 deleted the fix-add-to-sources branch March 27, 2022 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

document.add_to_sources() should also set VP_SOURCE
1 participant