Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix shapely 1.8 related warnings #342

Merged
merged 3 commits into from
Nov 21, 2021
Merged

Fix shapely 1.8 related warnings #342

merged 3 commits into from
Nov 21, 2021

Conversation

abey79
Copy link
Owner

@abey79 abey79 commented Nov 21, 2021

Description

Shapely is a transition release towards shapely 2.0, which deprecates certain element of the API (more info). This PR implement the required fixes to avoid deprecation warnings.

Checklist

  • feature/fix implemented
  • code formatting ok (black and isort)
  • mypy vpype vpype_cli tests returns no error
  • tests added/updated and pytest succeeds
  • documentation added/updated
    • command docstring and option/argument help
    • README.md updated (Feature Overview)
    • CHANGELOG.md updated
    • RTD doc updated and building with no error (make clean && make html in docs/)

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Nov 21, 2021

Codecov Report

Merging #342 (02146e9) into master (3e61761) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #342   +/-   ##
=======================================
  Coverage   92.35%   92.35%           
=======================================
  Files          50       50           
  Lines        3989     3991    +2     
  Branches      522      523    +1     
=======================================
+ Hits         3684     3686    +2     
  Misses        203      203           
  Partials      102      102           
Impacted Files Coverage Δ
vpype/model.py 91.47% <100.00%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e61761...02146e9. Read the comment docs.

@abey79 abey79 merged commit 6d56de5 into master Nov 21, 2021
@abey79 abey79 deleted the fix-shapely-1.8-warnings branch November 21, 2021 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant