Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle ctrl-C from terminal and close the viewer #321

Merged
merged 2 commits into from
Oct 18, 2021

Conversation

abey79
Copy link
Owner

@abey79 abey79 commented Oct 18, 2021

Description

This PR handle SIGINT signals from the viewer to close it when ctrl-C is used in the terminal.

Fixes #317

Checklist

  • feature/fix implemented
  • code formatting ok (black and isort)
  • mypy vpype vpype_cli tests returns no error
  • tests added/updated and pytest succeeds
  • documentation added/updated
    • command docstring and option/argument help
    • README.md updated (Feature Overview)
    • CHANGELOG.md updated
    • RTD doc updated and building with no error (make clean && make html in docs/)

@codecov
Copy link

codecov bot commented Oct 18, 2021

Codecov Report

Merging #321 (bfe2ad1) into master (000e328) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #321   +/-   ##
=======================================
  Coverage   92.06%   92.06%           
=======================================
  Files          50       50           
  Lines        3945     3945           
  Branches      520      520           
=======================================
  Hits         3632     3632           
  Misses        209      209           
  Partials      104      104           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 000e328...bfe2ad1. Read the comment docs.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@abey79 abey79 merged commit ea7dadc into master Oct 18, 2021
@abey79 abey79 deleted the feature-keyboard-interrupt branch October 18, 2021 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Close viewer from terminal
1 participant