Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HPGL: change velocity to int #286

Merged
merged 3 commits into from
Jun 7, 2021
Merged

HPGL: change velocity to int #286

merged 3 commits into from
Jun 7, 2021

Conversation

abey79
Copy link
Owner

@abey79 abey79 commented Jun 7, 2021

Description

  • write -f hpgl now only accepts int for -velocity/--vs
  • HPGL outputs VS command with int value only

Fixes #255

Checklist

  • feature/fix implemented
  • code formatting ok (black and isort)
  • mypy vpype vpype_cli tests returns no error
  • tests added/updated and pytest succeeds
  • documentation added/updated
    • command docstring and option/argument help
    • README.md updated (Feature Overview)
    • CHANGELOG.md updated
    • RTD doc updated and building with no error (make clean && make html in docs/)

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 7, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Jun 7, 2021

Codecov Report

Merging #286 (076db1c) into master (23b4846) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #286   +/-   ##
=======================================
  Coverage   91.72%   91.72%           
=======================================
  Files          50       50           
  Lines        3794     3794           
  Branches      495      495           
=======================================
  Hits         3480     3480           
  Misses        210      210           
  Partials      104      104           
Impacted Files Coverage Δ
vpype/io.py 75.08% <0.00%> (ø)
vpype_cli/write.py 84.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23b4846...076db1c. Read the comment docs.

@abey79 abey79 merged commit 9f7837c into master Jun 7, 2021
@abey79 abey79 deleted the fix-255-hpgl-vs-int branch June 7, 2021 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove decimal point from VS command
1 participant