Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Click to 8.0.1 and fix compatibility #282

Merged
merged 2 commits into from
May 31, 2021
Merged

Bump Click to 8.0.1 and fix compatibility #282

merged 2 commits into from
May 31, 2021

Conversation

abey79
Copy link
Owner

@abey79 abey79 commented May 31, 2021

Description

Fixes #273

Checklist

  • feature/fix implemented
  • code formatting ok (black and isort)
  • mypy vpype vpype_cli tests returns no error
  • tests added/updated and pytest succeeds
  • documentation added/updated
    • command docstring and option/argument help
    • README.md updated (Feature Overview)
    • CHANGELOG.md updated
    • RTD doc updated and building with no error (make clean && make html in docs/)

@codecov
Copy link

codecov bot commented May 31, 2021

Codecov Report

Merging #282 (ba3011b) into master (fa37d04) will decrease coverage by 0.03%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #282      +/-   ##
==========================================
- Coverage   91.80%   91.77%   -0.04%     
==========================================
  Files          50       50              
  Lines        3784     3794      +10     
  Branches      491      495       +4     
==========================================
+ Hits         3474     3482       +8     
- Misses        208      209       +1     
- Partials      102      103       +1     
Impacted Files Coverage Δ
vpype/layers.py 77.14% <66.66%> (+1.38%) ⬆️
vpype/utils.py 85.50% <73.33%> (-1.80%) ⬇️
vpype_cli/cli.py 73.41% <75.00%> (ø)
tests/test_commands.py 99.59% <100.00%> (ø)
vpype_cli/transforms.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa37d04...ba3011b. Read the comment docs.

- changelog updated
- updated to 8.0.1
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@abey79 abey79 merged commit a5d4637 into master May 31, 2021
@abey79 abey79 deleted the fix-click8 branch May 31, 2021 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix crash with Click 8.0
1 participant