Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Single port server #55

Merged
merged 3 commits into from
Jul 20, 2020
Merged

Single port server #55

merged 3 commits into from
Jul 20, 2020

Conversation

saurabhdaware
Copy link
Member

What type of PR is this?

  • Feature
  • Bug Fix
  • Refactor
  • Documentation Update

Description

Removes the need of another port for socket server. Now both servers will be served from the same port (defaullt: 5000)

Added unit tests?

  • No, I want help in writing tests.
  • No, I want someone else to write tests.
  • No, The addition does not need tests.
  • Yes

[optional] Random GIF to +1 someone's day

saurabhdaware
saurabhdaware commented Jul 20, 2020
View reviewed changes
Copy link
Member Author

@saurabhdaware saurabhdaware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️ v cool saurabh

@saurabhdaware saurabhdaware merged commit 3e87586 into main Jul 20, 2020
@saurabhdaware saurabhdaware deleted the single-port-server branch July 20, 2020 17:56
@saurabhdaware saurabhdaware mentioned this pull request Jul 20, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@saurabhdaware