Skip to content

Commit

Permalink
fix(select): make native validation visible in DOM
Browse files Browse the repository at this point in the history
  • Loading branch information
abelflopes committed Oct 24, 2024
1 parent a547597 commit 91b0398
Showing 1 changed file with 18 additions and 17 deletions.
35 changes: 18 additions & 17 deletions packages/components/select/src/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -171,23 +171,6 @@ const Select = ({

return (
<>
<select
ref={selectRef}
name={selectName}
multiple={selectMultiple}
defaultValue={defaultValue}
value={internalValue}
hidden
onChange={(e) => {
selectOnChange?.(e, selectedValuesList);
}}>
{selectedValuesList.map((i) => (
<option key={i} value={i}>
{i}
</option>
))}
</select>

<div
{...props}
ref={rootElRef}
Expand All @@ -203,6 +186,24 @@ const Select = ({
onBlur?.(e);
}}>
{displayValue || <span className={styles.placeholder}>{placeholder}</span>}

<select
ref={selectRef}
name={selectName}
multiple={selectMultiple}
defaultValue={defaultValue}
required={required}
value={internalValue}
className={styles.native_element}
onChange={(e) => {
selectOnChange?.(e, selectedValuesList);
}}>
{selectedValuesList.map((i) => (
<option key={i} value={i}>
{i}
</option>
))}
</select>
</div>

<Dropdown
Expand Down

0 comments on commit 91b0398

Please sign in to comment.