fix(input): use native ref instead of custom ref

abelflopes · Aug 9, 2024 · 23550f5 · 23550f5
1 parent ecc50da
commit 23550f5
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 7 deletions.
diff --git a/packages/components/input/src/index.tsx b/packages/components/input/src/index.tsx
@@ -1,12 +1,15 @@
-import React, { useEffect, useMemo } from "react";
 import styles from "./styles/index.module.scss";
+import React, {
+  type ComponentPropsWithRef,
+  type HTMLInputTypeAttribute,
+  useEffect,
+  useMemo,
+} from "react";
 import { useFormFieldContext, type FormFieldContextProps } from "@react-ck/form-field";
 import classNames from "classnames";
 
-export interface InputProps extends Omit<React.InputHTMLAttributes<HTMLInputElement>, "children"> {
+export interface InputProps extends Omit<ComponentPropsWithRef<"input">, "children"> {
   skin?: FormFieldContextProps["skin"];
-  /** Ref for the root element */
-  rootRef?: React.ForwardedRef<HTMLInputElement>;
 }
 
 /**
@@ -17,7 +20,6 @@ export interface InputProps extends Omit<React.InputHTMLAttributes<HTMLInputElem
 
 export const Input = ({
   skin,
-  rootRef,
   id,
   className,
   ...props
@@ -44,7 +46,6 @@ export const Input = ({
   return (
     <input
       {...props}
-      ref={rootRef}
       id={computedId}
       className={classNames(
         styles.root,

diff --git a/packages/components/select/src/index.tsx b/packages/components/select/src/index.tsx
@@ -225,7 +225,7 @@ const Select = ({
                 placeholder={searchOptions.placeholder}
                 skin="ghost"
                 className={styles.search_input}
-                rootRef={(e) => {
+                ref={(e) => {
                   e?.focus();
                 }}
                 onChange={(e) => {