Fixed bug in -deleteFile:error: that causes a buffer overrun vulnerab…

…ility (Issue #106)
abbeycode · Mar 14, 2021 · 86dd120 · 86dd120
1 parent b60747b
commit 86dd120
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/Source/UZKArchive.m b/Source/UZKArchive.m
@@ -1461,7 +1461,7 @@ - (BOOL)deleteFile:(NSString *)filePath error:(NSError * __autoreleasing*)error
             }
 
             UZKLogDebug("Allocating commentary");
-            char *commentary = (char*)malloc(unzipInfo.size_file_comment);
+            char *commentary = unzipInfo.size_file_comment > 0 ? (char*)malloc(unzipInfo.size_file_comment) : NULL;
             if ((commentary == NULL) && (unzipInfo.size_file_comment != 0)) {
                 NSString *detail = [NSString localizedStringWithFormat:NSLocalizedStringFromTableInBundle(@"Error allocating commentary info of %@ while deleting %@", @"UnzipKit", _resources, @"Detailed error string"),
                                     currentFileName, filePath];