Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add rust-toolchain, current nightly breaks compile so force stable. #158

Closed
wants to merge 1 commit into from
Closed

add rust-toolchain, current nightly breaks compile so force stable. #158

wants to merge 1 commit into from

Conversation

JustASpeedrunner
Copy link

Was having an issue compiling since I had cargo on nightly, this forces stable so those issues don't come up on other peoples' machines.

Output if built with nightly:

spotify-adblock $ make
# cargo build --profile release
cargo build --release
   Compiling proc-macro2 v1.0.55
   Compiling unicode-ident v1.0.8
   Compiling quote v1.0.26
   Compiling serde_derive v1.0.159
   Compiling serde v1.0.159
   Compiling memchr v2.5.0
   Compiling autocfg v1.1.0
   Compiling hashbrown v0.12.3
   Compiling regex-syntax v0.6.29
   Compiling winnow v0.4.1
   Compiling libc v0.2.140
   Compiling lazy_static v1.4.0
   Compiling indexmap v1.9.3
error[E0635]: unknown feature `proc_macro_span_shrink`
  --> /home/jas/.cargo/registry/src/index.crates.io-6f17d22bba15001f/proc-macro2-1.0.55/src/lib.rs:92:30
   |
92 |     feature(proc_macro_span, proc_macro_span_shrink)
   |                              ^^^^^^^^^^^^^^^^^^^^^^

For more information about this error, try `rustc --explain E0635`.
error: could not compile `proc-macro2` (lib) due to previous error
warning: build failed, waiting for other jobs to finish...
make: *** [Makefile:14: target/release/libspotifyadblock.so] Error 101

@abba23
Copy link
Owner

abba23 commented Jul 21, 2023

I just updated the dependencies in Cargo.lock (proc-macro2 in particular), which should make it possible to build the project with nightly Rust again.

@JustASpeedrunner
Copy link
Author

Yep it works now, I would add the toolchain just for stability's sake but it's up to you. Regardless I appreciate the fix.

@abba23
Copy link
Owner

abba23 commented Jul 22, 2023

it works now

Great! Thank you for pointing out the problem.

I would add the toolchain just for stability's sake but it's up to you.

I think some potential instability should be expected when using nightly. But since there's no fundamental incompatibility here, I don't believe the restriction is necessary in this case.

@abba23 abba23 closed this Jul 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants