-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
パーサーの仕様を変更 #130
Merged
パーサーの仕様を変更 #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
インターフェースと実装、および構文ごとのノード定義を分離した
LeafNodeとNonLeafNodeの区別がなくなったことに伴い、仕様を変更。根かどうかのフラグを渡す仕様から、呼び出し側で加工させる仕様に変更した。
Markdown全体のパースを補助するクラス reader を実装した。メタデータの取り出しは reader を経由して行うが、未実装。
具体的な構文のパース方法については別個定義するように設計を見直した。
abap34
requested changes
May 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ありがとう!
ロジックのところは後でじっくりみます。これだけ先に修正お願いします
全 7 種の実装が完了した
meta_data を参照で保持
すべての構文を定義し終えて、
とかで試せるはず。 |
abap34
requested changes
May 31, 2024
class は予約語なので div_class とした
abap34
approved these changes
Jun 4, 2024
良さそうです。お疲れ様でした! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #65
fix #71
大量の仕様変更を行なっている;
大きめの変更
void
を返す仕様に変更NonLeaf
とLeaf
の区別を撤廃Reader
クラスを作成Block
構文とInline
構文を定義、パーサーを関数オブジェクトとして提供させる仕様にした小さめの変更
int
に変更Block::render
が担っていた機能をto_html
が担うよう変更、render
を削除InlineParser
はインスタンスを生成せずに文字列をパースできる仕様に変更EOF
を追加、なお、これはASTには現れないRawText
は特別にパーサーを持たず、InlineParser
が実質的なパーサーを担当するrender.hpp
のmd_to_dot
を参照のこと)