Merge pull request #124 from abap34/bug/#116

環境変数ではなくファイル経由でバージョン情報を共有するように変更
abap34 · May 18, 2024 · 8b4da2a · 8b4da2a
2 parents 5fe7c8b + 960654c
commit 8b4da2a
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/.github/workflows/pypi.yaml b/.github/workflows/pypi.yaml
@@ -20,7 +20,9 @@ jobs:
             pip install setuptools wheel twine pybind11
 
         - name: Build package
-          run: env VERSION=$(git describe --tags --abbrev=0) python setup.py sdist 
+          run: |
+            git describe --tags --abbrev=0 > version.txt
+            python setup.py sdist 
 
         - name: Upload package to PyPI
           uses: pypa/gh-action-pypi-publish@release/v1

diff --git a/MANIFEST.in b/MANIFEST.in
@@ -1,2 +1,3 @@
 include src/*
 include scripts/setup.sh
+include version.txt
diff --git a/setup.py b/setup.py
@@ -3,7 +3,8 @@
 from setuptools import setup
 
 os.system("bash scripts/setup.sh")
-__version__ = os.getenv("VERSION")
+with open("version.txt") as f:
+    __version__ = f.read().strip()
 
 ext_modules = [
     Pybind11Extension(