Draft: #271: Update Windows image from 2016 to 2019 #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #273 +/- ##
==========================================
- Coverage 93.80% 93.76% -0.04%
==========================================
Files 23 23
Lines 2856 2870 +14
==========================================
+ Hits 2679 2691 +12
- Misses 177 179 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
rzr
changed the title
|
thx, to block merge i think there is a draft option you can set and unset from gh |
|
ping |
|
to unblock you, I'll release a version if this is fixed |
|
is it worth merging this draft ? |
|
please rebase |
|
can it be ready for next release before 2023 ? |
|
I included this commit here 51b5726 so this pull request is obsolete. |
|
please rebase to fix conflict |
|
I think can be closed because done via #287 |
|
Please rebase or close |
|
@rzr simply close, this is already done if you check the github action which is currently in master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CI pipeline is still using the windows-2016 image which has been phased out by GitHub earlier this year (see: actions/runner-images#4312). This causes no runners being available for picking up the win32 package/build steps, with them eventually timing out.
This initial PR bumps up the Windows image version used from 2016 to 2019. If things fail, we should now at least get an error message telling what's wrong.
Please do not merge yet. Thanks!