Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#271: Update npm-publish-action to latest version #272

Merged
merged 1 commit into from
Sep 24, 2022
Merged

#271: Update npm-publish-action to latest version #272

merged 1 commit into from
Sep 24, 2022

Conversation

swgnr
Copy link

@swgnr swgnr commented Sep 22, 2022

Hi!

I saw that that there's currently an issue going on with publishing the package to npm in #271. It seems that a recent git update now checks whether the folder into which a repo is cloned is owned by the same user running the 'git' executable for security purposes.

A fix has already been merged in npm-publish-action some while ago (see: pascalgn/npm-publish-action#42). This PR would update the version of the plugin to the latest stable release.

With any luck, those should be the only changes needed.

Thanks for keeping noble alive! :)

@donavanbecker
Copy link

@rzr

@swgnr
Copy link
Author

swgnr commented Sep 23, 2022

Just as an addendum: This will not fix the Win32 build actions. It looks like the CI pipeline is still using the windows-2016 image which has been phased out by GitHub earlier this year (see actions/runner-images#4312).

I saw that there have already been attempts at upgrading the Windows image earlier (see: 56c46b2), but those changes got reverted.

Trying to further look into this, though I'm not really familiar with Windows development stuff.

@codecov-commenter
Copy link

Codecov Report

Merging #272 (87af9cf) into master (057f69f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #272   +/-   ##
=======================================
  Coverage   93.80%   93.80%           
=======================================
  Files          23       23           
  Lines        2856     2856           
=======================================
  Hits         2679     2679           
  Misses        177      177           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@rzr rzr merged commit 1fe20d1 into abandonware:master Sep 24, 2022
@swgnr swgnr deleted the update-npm-publish-plugin branch September 25, 2022 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants