Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add v1 export #14

Merged
merged 8 commits into from
Jan 11, 2021
Merged

refactor: add v1 export #14

merged 8 commits into from
Jan 11, 2021

Conversation

sakulstra
Copy link
Contributor

@sakulstra sakulstra commented Dec 5, 2020

I'd personally have prefered 2 entry points @aave/protocol-js/v1 and @aave/protocol-js/v2, but tsdx doesn't provide a way to provide multiple entry points by default i created a less nice workaround which also seems to work.

What this pr does

  1. exports all helpers & utils from index js (missed e.g. raymath at multiple places an inlined it instead in projects - this should help keeping the code cleaner)
  2. exports all v2 stuff from the root like it currently is to not be breaking
  3. adds a named export for each version. If you want to use v1 stuff you can now import { v1 } from "@aave/protocol-js"; v1.formatReserves();

@sakulstra sakulstra marked this pull request as draft December 6, 2020 12:13
@sakulstra sakulstra marked this pull request as ready for review January 7, 2021 15:40
@kyzia551 kyzia551 merged commit 6c74c6d into v2 Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants