Use Attribute.GetCustomAttributes to reduce allocations / improve performance #953
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the project no longer targets
netstandard1.3
, we can replace the custom implementation insideReflectionExtensions.GetAllCustomAttributes()
withAttribute.GetCustomAttributes()
.In addition to simpler code, in the provided benchmark this eliminates 4
List<Attribute>
allocations per serialized element. In the benchmark that results in ~10% less CPU time and ~5% fewer allocations.Here's the added BenchmarkDotNet results on my machine:
Before
After
and here's the object allocation graph for a single iteration of the benchmark:
Before
After