Optimize YamlScalarNode.Load and YamlMappingNode.Load #927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lahma
force-pushed
the
optimize-scalar-load
branch
from
b83c800 to
754d5c5
Compare
* check for "null" marker faster * don't do try-catch in a loop
lahma
force-pushed
the
optimize-scalar-load
branch
from
754d5c5 to
7964734
Compare
|
This feature has been released in version 16.0.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improving scalar loading performance a bit as it's done a lot for common files. Check for "null" marker faster and don't do try-catch in a loop. I fixed the saltern example YAML file for easier testing.
The OrderedDictionary change looks large, but it seems that it has been stored in Git with wrong newlines and always pops up as modified otherwise. If you check ignore whitespace in PR view that should help.
YamlDotNet.Benchmark.YamlStreamBenchmark