Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

French translation #7

Merged
merged 33 commits into from
Sep 12, 2020
Merged

French translation #7

merged 33 commits into from
Sep 12, 2020

Conversation

nlehuen
Copy link
Contributor

@nlehuen nlehuen commented Sep 12, 2020

Hi, here is a first go at the French translation.

@nlehuen
Copy link
Contributor Author

nlehuen commented Sep 12, 2020

Please note that I've added a sentence towards the end crediting myself for the translation.

@aatishb
Copy link
Owner

aatishb commented Sep 12, 2020

Thanks for this! I'll work on combining with the recent changes and then I'll review.

@aatishb
Copy link
Owner

aatishb commented Sep 12, 2020

Hi @nlehuen, I just merged a few changes to bring this closer to the main branch. Here are some remaining things to do:

  • In the header of index.html, index-fr.html, index-he.html, translate the link 'French' to French
  • In the header of index-fr.html, translate the word 'by'
  • In index-fr.html, translate Contagious Person and Susceptible Person for all four routes
  • In index-fr.html, translate graph titles and annotations for both graphs

Thanks!

@aatishb
Copy link
Owner

aatishb commented Sep 12, 2020

Tagging #4

@nlehuen
Copy link
Contributor Author

nlehuen commented Sep 12, 2020

Please don't merge yet, I have broken the page layout. Looking into this...

@aatishb
Copy link
Owner

aatishb commented Sep 12, 2020 via email

@nlehuen
Copy link
Contributor Author

nlehuen commented Sep 12, 2020

@aatishb, I'm good now, you can merge at your convenience.

@aatishb aatishb merged commit eac2a6a into aatishb:master Sep 12, 2020
@aatishb
Copy link
Owner

aatishb commented Sep 12, 2020

@nlehuen Merged. Thanks for your thorough work on this, and also for merging the main branch & resolving conflicts. :) Appreciate your help.

@aatishb
Copy link
Owner

aatishb commented Sep 12, 2020

@all-contributors add @nlehuen for translation

@allcontributors
Copy link
Contributor

@aatishb

I've put up a pull request to add @nlehuen! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants