-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
French translation #7
Conversation
Please note that I've added a sentence towards the end crediting myself for the translation. |
Thanks for this! I'll work on combining with the recent changes and then I'll review. |
Hi @nlehuen, I just merged a few changes to bring this closer to the main branch. Here are some remaining things to do:
Thanks! |
Tagging #4 |
Please don't merge yet, I have broken the page layout. Looking into this... |
no worries & no hurry, let me know whenever I should take a look.
…________________________________
From: Nicolas Lehuen <notifications@github.com>
Sent: Saturday, September 12, 2020 10:43:09 AM
To: aatishb/maskmath <maskmath@noreply.github.com>
Cc: Aatish Bhatia <aatish@gmail.com>; Comment <comment@noreply.github.com>
Subject: Re: [aatishb/maskmath] French translation (#7)
Please don't merge yet, I have broken the page layout. Looking into this...
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub<#7 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAOKU3W2QHQYPU2CLRJO2HLSFOCH3ANCNFSM4RJM3BZQ>.
|
What happened to error messages?
@aatishb, I'm good now, you can merge at your convenience. |
@nlehuen Merged. Thanks for your thorough work on this, and also for merging the main branch & resolving conflicts. :) Appreciate your help. |
@all-contributors add @nlehuen for translation |
I've put up a pull request to add @nlehuen! 🎉 |
Hi, here is a first go at the French translation.