Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persian (Farsi) translations #45

Merged
merged 6 commits into from
Oct 2, 2020
Merged

Conversation

alisabzevari
Copy link
Contributor

@alisabzevari alisabzevari commented Oct 1, 2020

Related to #4,

This PR adds Persian translations.

@aatishb
Copy link
Owner

aatishb commented Oct 1, 2020

Hi @alisabzevari, thanks for working on this! I'll go ahead and merge the live version into this branch, and will let you know if there are any steps remaining.

Copy link
Owner

@aatishb aatishb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @alisabzevari thanks for working on this, I love the typography! Could you add in these few remaining translations, that should bring us to 100%.

index-fa.html Outdated Show resolved Hide resolved
index-fa.html Outdated Show resolved Hide resolved
index-fa.html Outdated Show resolved Hide resolved
index-fa.html Outdated Show resolved Hide resolved
index-fa.html Outdated Show resolved Hide resolved
@aatishb
Copy link
Owner

aatishb commented Oct 2, 2020

Tagging #4

@alisabzevari
Copy link
Contributor Author

I have addressed the comments. Please take another look.

@aatishb aatishb merged commit 662013a into aatishb:master Oct 2, 2020
@aatishb
Copy link
Owner

aatishb commented Oct 2, 2020

@alisabzevari thanks so much for your work on this! Merged.

@aatishb
Copy link
Owner

aatishb commented Oct 2, 2020

@all-contributors add @alisabzevari for translation

@allcontributors
Copy link
Contributor

@aatishb

I've put up a pull request to add @alisabzevari! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants