forked from llvm/llvm-project
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[AArch64][GlobalISel] Mark some vector G_ABS cases as legal
Each of the cases marked as legal here have an imported pattern in AArch64GenGlobalISel.inc. So, if we mark them as legal, we get selection for free. Technically this is only supposed to happen if we have NEON support. But, we fall back if we don't have that in the legalizer right now. I suppose it'd be better to have a FIXME so we can write the testcase when the time comes. (Plus, it'd just fall back in selection if NEON isn't available, so it's not *wrong*, I guess?) This fixes some fallbacks in the test suite. (Also use `isScalar` from LegalityPredicates.cpp while we're here just to tidy things a little bit.) Differential Revision: https://reviews.llvm.org/D100916
- Loading branch information
Jessica Paquette
committed
Apr 22, 2021
1 parent
1a71908
commit 6cb7599
Showing
3 changed files
with
248 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,130 @@ | ||
# NOTE: Assertions have been autogenerated by utils/update_mir_test_checks.py | ||
# RUN: llc -mtriple=aarch64-apple-ios -run-pass=instruction-select %s -o - | FileCheck %s | ||
|
||
... | ||
--- | ||
name: v4s16 | ||
legalized: true | ||
regBankSelected: true | ||
tracksRegLiveness: true | ||
body: | | ||
bb.0: | ||
liveins: $d0 | ||
; CHECK-LABEL: name: v4s16 | ||
; CHECK: liveins: $d0 | ||
; CHECK: [[COPY:%[0-9]+]]:fpr64 = COPY $d0 | ||
; CHECK: [[ABSv4i16_:%[0-9]+]]:fpr64 = ABSv4i16 [[COPY]] | ||
; CHECK: $d0 = COPY [[ABSv4i16_]] | ||
; CHECK: RET_ReallyLR implicit $d0 | ||
%0:fpr(<4 x s16>) = COPY $d0 | ||
%1:fpr(<4 x s16>) = G_ABS %0 | ||
$d0 = COPY %1(<4 x s16>) | ||
RET_ReallyLR implicit $d0 | ||
... | ||
--- | ||
name: v8s16 | ||
legalized: true | ||
regBankSelected: true | ||
tracksRegLiveness: true | ||
body: | | ||
bb.0: | ||
liveins: $q0 | ||
; CHECK-LABEL: name: v8s16 | ||
; CHECK: liveins: $q0 | ||
; CHECK: [[COPY:%[0-9]+]]:fpr128 = COPY $q0 | ||
; CHECK: [[ABSv8i16_:%[0-9]+]]:fpr128 = ABSv8i16 [[COPY]] | ||
; CHECK: $q0 = COPY [[ABSv8i16_]] | ||
; CHECK: RET_ReallyLR implicit $q0 | ||
%0:fpr(<8 x s16>) = COPY $q0 | ||
%1:fpr(<8 x s16>) = G_ABS %0 | ||
$q0 = COPY %1(<8 x s16>) | ||
RET_ReallyLR implicit $q0 | ||
... | ||
--- | ||
name: v2s32 | ||
legalized: true | ||
regBankSelected: true | ||
tracksRegLiveness: true | ||
body: | | ||
bb.0: | ||
liveins: $d0 | ||
; CHECK-LABEL: name: v2s32 | ||
; CHECK: liveins: $d0 | ||
; CHECK: [[COPY:%[0-9]+]]:fpr64 = COPY $d0 | ||
; CHECK: [[ABSv2i32_:%[0-9]+]]:fpr64 = ABSv2i32 [[COPY]] | ||
; CHECK: $d0 = COPY [[ABSv2i32_]] | ||
; CHECK: RET_ReallyLR implicit $d0 | ||
%0:fpr(<2 x s32>) = COPY $d0 | ||
%1:fpr(<2 x s32>) = G_ABS %0 | ||
$d0 = COPY %1(<2 x s32>) | ||
RET_ReallyLR implicit $d0 | ||
... | ||
--- | ||
name: v4s32 | ||
legalized: true | ||
regBankSelected: true | ||
tracksRegLiveness: true | ||
body: | | ||
bb.0: | ||
liveins: $q0 | ||
; CHECK-LABEL: name: v4s32 | ||
; CHECK: liveins: $q0 | ||
; CHECK: [[COPY:%[0-9]+]]:fpr128 = COPY $q0 | ||
; CHECK: [[ABSv4i32_:%[0-9]+]]:fpr128 = ABSv4i32 [[COPY]] | ||
; CHECK: $q0 = COPY [[ABSv4i32_]] | ||
; CHECK: RET_ReallyLR implicit $q0 | ||
%0:fpr(<4 x s32>) = COPY $q0 | ||
%1:fpr(<4 x s32>) = G_ABS %0 | ||
$q0 = COPY %1(<4 x s32>) | ||
RET_ReallyLR implicit $q0 | ||
... | ||
--- | ||
name: v4s8 | ||
legalized: true | ||
regBankSelected: true | ||
tracksRegLiveness: true | ||
body: | | ||
bb.0: | ||
liveins: $d0 | ||
; CHECK-LABEL: name: v4s8 | ||
; CHECK: liveins: $d0 | ||
; CHECK: [[COPY:%[0-9]+]]:fpr64 = COPY $d0 | ||
; CHECK: [[ABSv8i8_:%[0-9]+]]:fpr64 = ABSv8i8 [[COPY]] | ||
; CHECK: $d0 = COPY [[ABSv8i8_]] | ||
; CHECK: RET_ReallyLR implicit $d0 | ||
%0:fpr(<8 x s8>) = COPY $d0 | ||
%1:fpr(<8 x s8>) = G_ABS %0 | ||
$d0 = COPY %1(<8 x s8>) | ||
RET_ReallyLR implicit $d0 | ||
... | ||
--- | ||
name: v16s8 | ||
legalized: true | ||
regBankSelected: true | ||
tracksRegLiveness: true | ||
body: | | ||
bb.0: | ||
liveins: $q0 | ||
; CHECK-LABEL: name: v16s8 | ||
; CHECK: liveins: $q0 | ||
; CHECK: [[COPY:%[0-9]+]]:fpr128 = COPY $q0 | ||
; CHECK: [[ABSv16i8_:%[0-9]+]]:fpr128 = ABSv16i8 [[COPY]] | ||
; CHECK: $q0 = COPY [[ABSv16i8_]] | ||
; CHECK: RET_ReallyLR implicit $q0 | ||
%0:fpr(<16 x s8>) = COPY $q0 | ||
%1:fpr(<16 x s8>) = G_ABS %0 | ||
$q0 = COPY %1(<16 x s8>) | ||
RET_ReallyLR implicit $q0 | ||
... |