Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sidecar.app_name config variable #83

Merged
merged 9 commits into from
Sep 9, 2022

Conversation

wilsenhc
Copy link
Contributor

This PR adds a new config variable sidecar.app_name.

Currently I'm working on a rewrite of an application which uses Sidecar, and for both apps the APP_NAME is exactly the same (since one will eventually replace the other one) and when deploying Sidecar functions which are named the same one replaces the other.

This could solve then problem, letting us define a different internal name when deploying to AWS

Add paranthesis
Change test scope
Fix namespace function name
Update test
@wilsenhc wilsenhc marked this pull request as draft August 18, 2022 23:43
@wilsenhc
Copy link
Contributor Author

Doesn't make sense to me why almost all prefer-lowest tests are failing.

Any thoughts on that? @aarondfrancis

@aarondfrancis aarondfrancis marked this pull request as ready for review September 9, 2022 20:15
Copy link
Owner

@aarondfrancis aarondfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing PR, thank so much for adding the tests and docs as well. That's a huge help!

I adjusted the test just a little bit, and also made the prefers-lowest tests pass by mucking around with the getEnvironmentSetup thing. Apparently that's the old name for it, so it works with the lowest constraint. (See: https://packages.tools/testbench/basic/define-environment.html#define-environment.)

Thanks again! I'll cut a release with this soon 🎉

@aarondfrancis aarondfrancis merged commit c407d82 into aarondfrancis:main Sep 9, 2022
@wilsenhc
Copy link
Contributor Author

Thanks for the help with the tests!

And I appreciate that you liked it 🥳

Hope to see the new release soon to upgrade the projects where I'm using the package.

Thanks Aaron!

@wilsenhc wilsenhc deleted the add-app-name-config branch April 5, 2024 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants