-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sidecar.app_name
config variable
#83
Add sidecar.app_name
config variable
#83
Conversation
07054b6
to
084e663
Compare
Add paranthesis Change test scope Fix namespace function name Update test
b1ca6fb
to
47ba81a
Compare
Doesn't make sense to me why almost all Any thoughts on that? @aarondfrancis |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing PR, thank so much for adding the tests and docs as well. That's a huge help!
I adjusted the test just a little bit, and also made the prefers-lowest
tests pass by mucking around with the getEnvironmentSetup
thing. Apparently that's the old name for it, so it works with the lowest
constraint. (See: https://packages.tools/testbench/basic/define-environment.html#define-environment.)
Thanks again! I'll cut a release with this soon 🎉
Thanks for the help with the tests! And I appreciate that you liked it 🥳 Hope to see the new release soon to upgrade the projects where I'm using the package. Thanks Aaron! |
This PR adds a new config variable
sidecar.app_name
.Currently I'm working on a rewrite of an application which uses Sidecar, and for both apps the
APP_NAME
is exactly the same (since one will eventually replace the other one) and when deploying Sidecar functions which are named the same one replaces the other.This could solve then problem, letting us define a different internal name when deploying to AWS