Gracefully handle unexpected log output #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It also looks like if the sidecar handler has a very large log output, it will get truncated, causing the parser to break. It looks like it only keeps some specific number of bytes, so the beginning of the log output can be missing. Since the parser splits by new lines and then looks at the beginning of each line, this can be a problem if the first line starts part-way through a truncated log message. |
|
I think the whole logging thing needs to be improved and this is a good step in that direction. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a band aid for #65 — it doesn't necessarily fix the issue, but it at least ensures that if Sidecar runs into log output that it doesn't expect, it doesn't completely fail.