Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update supported Runtimes #123

Merged

Conversation

wilsenhc
Copy link
Contributor

@wilsenhc wilsenhc commented Jun 9, 2023

This PR updates the list of supported runtimes to the current supported runtimes listed in the Lambda runtimes docs page.

This PR also updates the default runtime for Lambda Functions to be latest Node.js LTS version.

Last but not least, this PR also updated the docs to be consistent with the list of Lambda Runtimes

@wilsenhc
Copy link
Contributor Author

Sorry to bother, just a quick ping/reminder @aarondfrancis

@aarondfrancis
Copy link
Owner

Can we leave the default runtime as 14, and then it's not a breaking change? We'll have to do it eventually, but I'd rather wait as long as possible

@wilsenhc
Copy link
Contributor Author

@aarondfrancis We could leave the default value in the LambdaFunction class to be Node.js v14 but recommend/give examples in the documentation to use the latest Node.js LTS version?

Also now that I think of it, adding a make:lambda-function command is something that would make sense?
And in there you could "enforce" newer versions of the runtime just by using a stub file that would only be used to create new functions without affecting existing ones?

@wilsenhc
Copy link
Contributor Author

@aarondfrancis

Also, just to add a note here: according to Node.js releases cycle Node.js v14 is already unsupported so it may not be long before AWS stops supporting it as a Lambda Runtime too.

@wilsenhc wilsenhc changed the title [Breaking change] Update supported Runtimes Update supported Runtimes Jul 4, 2023
@wilsenhc
Copy link
Contributor Author

wilsenhc commented Jul 4, 2023

@aarondfrancis I've udated the title of this PR to reflect that this is not a breaking change anymore!

@wilsenhc
Copy link
Contributor Author

wilsenhc commented Aug 3, 2023

I've just updated this PR since AWS added support for Python 3.11 just a few days ago.

@aarondfrancis

@wilsenhc
Copy link
Contributor Author

@aarondfrancis
I have just updated this PR to add support for the nodejs20.x runtime that was recently added to AWS Lambda. Changelog here.

@mt-dev44
Copy link

mt-dev44 commented Dec 6, 2023

@aarondfrancis - Any thoughts on when this might get merged in?

@owenvoke
Copy link

owenvoke commented Jan 9, 2024

It would be great to add this as Node.js 14.x is now deprecated and cannot be used to create new Lambda functions.

src/Runtime.php Show resolved Hide resolved
src/Runtime.php Show resolved Hide resolved
@wilsenhc
Copy link
Contributor Author

I have updated this PR with your suggested changes @owenvoke

cc @aarondfrancis

@wilsenhc
Copy link
Contributor Author

At this point this PR has been open for 7 months, so I am not sure if this package has been abandoned or not.

cc'ing everyone that has participated in this @mt-dev44 @owenvoke @aarondfrancis

@aarondfrancis
Copy link
Owner

Sorry, been a while. Had a lot going on. I'll merge and tag

@aarondfrancis aarondfrancis merged commit 005009a into aarondfrancis:main Jan 10, 2024
@aarondfrancis
Copy link
Owner

Thanks for your patience @wilsenhc et al. Tagged a new release. I'll work through the backlog of other ones in the next few days

@wilsenhc wilsenhc deleted the feature/update-lambda-runtimes branch January 10, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants