Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implements what is hopefully a safer time limit check #83

Merged
merged 1 commit into from
Nov 23, 2023
Merged

Conversation

aarondandy
Copy link
Owner

@aarondandy aarondandy commented Nov 23, 2023

I don't know the root cause of the issue mentioned in #78 but I have a hunch this might be related. I'm hopeful that moving away from Environment.TickCount will at least make the code a bit more resilient. This change comes with some reduced performance when checking incorrect words, but I think it is worth the cost. Based on what I have read, Environment.TickCount isn't very reliable, especially after 25 days . I hope DateTime.Utc.Ticks can be more reliable.

@aarondandy aarondandy self-assigned this Nov 23, 2023
@aarondandy aarondandy merged commit a2ec6af into main Nov 23, 2023
2 checks passed
@aarondandy aarondandy deleted the utc-ticks branch November 23, 2023 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant