Add an install.ps1 script for Windows.
#93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `install.sh` script can still be used with Git bash, but hopefully this native PowerShell script is a bit more friendly for Windows users. Fixes a-scie#91
|
I'm pretty sure none of us has Windows / PowerShell experience; so this may just be educational reading. It was for me - learned a bit today. |
jsirois
commented
Sep 8, 2024
jsirois
commented
Sep 8, 2024
| @@ -180,10 +178,6 @@ while (($# > 0)); do | |||
| INSTALL_PREFIX="$2" | |||
| shift | |||
| ;; | |||
| --base-name | -b) | |||
There was a problem hiding this comment.
@kwlzn I got rid of this because I assume you just copy-pastaed from scie-pants. In that case there was a period of trial where the pants bash script was still in use where having a non-standard name was useful. We don't have that transition problem; so this knob seems gratuitous to me.
…g and use simpler function syntax.
|
Alright, I'm actually happy with this now. All good for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
install.shscript can still be used with Git bash, but hopefullythis native PowerShell script is a bit more friendly for Windows users.
Fixes #91