Add multi-row support for Database.insert #32
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
This PR adds adds multi-row insertion support to the
KLDatabase.Database.insert
method, providing massive speedups when inserting many rows of data at a a time.Previously, inserting rows one-by-one would commit the changes to the database after every row, which is a slow I/O operation (especially on computers with slower storage). When inserting hundreds of rows at once, it could take over 2 seconds in some cases! With these changes, when providing multiple rows to
insert
in a list, the database changes are only committed once at the end, increasing performance to ~30ms for the same data that took over 2 seconds during testing.Merge Checklist
closes #<issue-number>
to automatically close an issue