Improve intersections in some cases by extending untrimmed road edges… #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Don't think this is as relevant an idea now, closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… a bit. #136
I'm not sure we should do this. But just to discuss the idea...
seattle_slip_lanes improves:
Though this is a weird case, because got overlapping intersections, or very nearly.
aurora_sausage_link reveals an interesting problem.
It's OK before, but we create less minimal intersections, and then the road doesn't meet the intersection cleanly. Because the trimmed back center is right on a slight curve, when we project left and right, the miter/bevel/whatever join acts a bit differently.
Is this an idea worth pursuing and refining? I'm more tempted to focus on something like seattle_slip_lanes where it gets us a bit closer to something good, but keep focusing on this one test case and figure out everything needed to make it look better.