engines/jvm:fix - false positives on base64 encode/decode #974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matheusalcantarazup
requested review from
iancardosozup,
lucasbrunozup,
nathanmartinszup and
wiliansilvazup
as code owners
matheusalcantarazup
force-pushed
the
fix-rule-jvm-38
branch
from
56ea448 to
7bd5c81
Compare
matheusalcantarazup
force-pushed
the
fix-rule-jvm-38
branch
from
7bd5c81 to
46a22c1
Compare
wiliansilvazup
suggested changes
Feb 7, 2022
matheusalcantarazup
force-pushed
the
fix-rule-jvm-38
branch
from
46a22c1 to
22608d9
Compare
Previously the rules of encode/decode Base64 was reporting any string that had the value encode/decode which was generating a lot of false positive. This commit improve the regex of these rules to catch only the method call that match encode or decode on name. The type of rule HS-JVM-24 was changed from AndMatch to OrMatch to follow the same behaviour of HS-JVM-28. Fixes #816 Signed-off-by: Matheus Alcantara <matheus.alcantara@zup.com.br>
matheusalcantarazup
force-pushed
the
fix-rule-jvm-38
branch
from
22608d9 to
2e619c9
Compare
nathanmartinszup
approved these changes
Feb 8, 2022
iancardosozup
approved these changes
Feb 8, 2022
wiliansilvazup
approved these changes
Feb 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the rules of encode/decode Base64 was reporting any string
that had the value encode/decode which was generating a lot of false
positive. This commit improve the regex of these rules to catch only
the method call that match encode or decode on name.
The type of rule HS-JVM-24 was changed from AndMatch to OrMatch to
follow the same behaviour of HS-JVM-28.
Fixes #816
Signed-off-by: Matheus Alcantara matheus.alcantara@zup.com.br
- What I did
- How to verify it
- Description for the changelog